fix: add accessible fretbox voicing descriptions - #5560
Merged
Conversation
Owner
Author
|
Serialized merge gate stopped on a deterministic client test failure: ChordDiagram.test.jsx expected the first-position rendering text not to match /fr/, but the new accessible description contains “fret”. The required CI Gate is red, so this PR remains open with its claim intact. |
Expose muted, open, and absolute fret positions as screen-reader text alongside the visual chord diagrams so SongBook popovers and the chords-used strip remain understandable without SVG geometry.
atomantic
force-pushed
the
claim/issue-5556
branch
from
September 1, 2026 03:24
fa8710f to
4b8348d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
npm test -- --run src/components/songbook/ChordDiagram.test.jsxnpm test -- --run src/components/songbook/TabSheetView.test.jsxnpx biome check src/components/songbook/ChordDiagram.jsx src/components/songbook/ChordDiagram.test.jsxCloses #5556