Skip to content

Silence double-toasts in manuscript fixes + Local LLM status (#2669)#2759

Merged
atomantic merged 1 commit into
mainfrom
claim/issue-2669
Jul 18, 2026
Merged

Silence double-toasts in manuscript fixes + Local LLM status (#2669)#2759
atomantic merged 1 commit into
mainfrom
claim/issue-2669

Conversation

@atomantic

Copy link
Copy Markdown
Owner

Summary

Continues the double-toast sweep (Refs #2669). This batch covers the pipeline-manuscript + Local LLM leftover singles — three genuine sites where a caller's own error toast stacked on top of the auto-toasting request() helper.

  • ManuscriptCommentCard.jsxgeneratePipelineManuscriptFix and acceptPipelineManuscriptFix both run through useAsyncAction (which toasts its errorMessage on throw) and the auto-toasting helper. Now pass { silent: true }. generatePipelineManuscriptFix had no options param at all, so a backward-compatible trailing options = {} was threaded into the wrapper (the issue's explicitly-named leftover); acceptPipelineManuscriptFix already had one. This also makes the card's accept path consistent with the accept-all preview path, which was already silent.
  • LocalLlmTab.jsxloadStatus called getLocalLlmStatus() (toasting by default) and its .catch added toast.error('Failed to load local LLM status'). Now getLocalLlmStatus({ silent: true }).

Verified-but-left-alone false positives in this area: executeMessageAction (MessageDetail) is already silent: true in the wrapper; importGmailMbox (GmailMboxImportPanel) already spreads silent: true into options; the remaining LocalLlmTab catches either set state without toasting or rely on the single request() layer via runAction; every .catch in PipelineManuscriptEditor.jsx already passes { silent: true }.

Test plan

  • Updated arg-exact assertions for the new trailing options arg in ManuscriptCommentCard.test.jsx, PipelineManuscriptEditor.test.jsx (accept assertion already-silent in ManuscriptImpactPreview.test.jsx was unchanged).
  • cd client && npx vitest run on the affected suites (ManuscriptCommentCard, ManuscriptImpactPreview, PipelineManuscriptEditor, PipelineEditorialChecks.muteFilter, EditorialFindingsTriage, LocalLlmPlayground): 89 tests pass.

Remaining

This issue stays open — remaining un-swept batches (re-scan before claiming; every prior batch found the advertised list stale in both directions):

Already shipped — do not re-sweep: settings + JIRA (#2670), messages/calendar/sharing, pipeline stages/canvas (#2714), writers-room/universe/universeBuilder/digital-twin/media pages+hooks (#2682), apps/GitHub/misc (#2721), loras/media (#2723), digital-twin leftovers (#2730), creative director (#2743), meatspace health-forms (#2755).

#2669)

generatePipelineManuscriptFix/acceptPipelineManuscriptFix (via useAsyncAction) and
getLocalLlmStatus (loadStatus) each showed their own error toast on top of the
auto-toasting request() helper. Pass { silent: true } so a single toast fires;
thread a backward-compatible trailing options param into generatePipelineManuscriptFix
and update the arg-exact tests.
@atomantic
atomantic merged commit 1bd5825 into main Jul 18, 2026
2 checks passed
@atomantic
atomantic deleted the claim/issue-2669 branch July 18, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant