Silence double-toasts in manuscript fixes + Local LLM status (#2669)#2759
Merged
Conversation
#2669) generatePipelineManuscriptFix/acceptPipelineManuscriptFix (via useAsyncAction) and getLocalLlmStatus (loadStatus) each showed their own error toast on top of the auto-toasting request() helper. Pass { silent: true } so a single toast fires; thread a backward-compatible trailing options param into generatePipelineManuscriptFix and update the arg-exact tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the double-toast sweep (
Refs #2669). This batch covers the pipeline-manuscript + Local LLM leftover singles — three genuine sites where a caller's own error toast stacked on top of the auto-toastingrequest()helper.ManuscriptCommentCard.jsx—generatePipelineManuscriptFixandacceptPipelineManuscriptFixboth run throughuseAsyncAction(which toasts itserrorMessageon throw) and the auto-toasting helper. Now pass{ silent: true }.generatePipelineManuscriptFixhad nooptionsparam at all, so a backward-compatible trailingoptions = {}was threaded into the wrapper (the issue's explicitly-named leftover);acceptPipelineManuscriptFixalready had one. This also makes the card's accept path consistent with the accept-all preview path, which was already silent.LocalLlmTab.jsx—loadStatuscalledgetLocalLlmStatus()(toasting by default) and its.catchaddedtoast.error('Failed to load local LLM status'). NowgetLocalLlmStatus({ silent: true }).Verified-but-left-alone false positives in this area:
executeMessageAction(MessageDetail) is alreadysilent: truein the wrapper;importGmailMbox(GmailMboxImportPanel) already spreadssilent: trueinto options; the remaining LocalLlmTab catches either set state without toasting or rely on the singlerequest()layer viarunAction; every.catchinPipelineManuscriptEditor.jsxalready passes{ silent: true }.Test plan
optionsarg inManuscriptCommentCard.test.jsx,PipelineManuscriptEditor.test.jsx(accept assertion already-silent inManuscriptImpactPreview.test.jsxwas unchanged).cd client && npx vitest runon the affected suites (ManuscriptCommentCard, ManuscriptImpactPreview, PipelineManuscriptEditor, PipelineEditorialChecks.muteFilter, EditorialFindingsTriage, LocalLlmPlayground): 89 tests pass.Remaining
This issue stays open — remaining un-swept batches (re-scan before claiming; every prior batch found the advertised list stale in both directions):
Already shipped — do not re-sweep: settings + JIRA (#2670), messages/calendar/sharing, pipeline stages/canvas (#2714), writers-room/universe/universeBuilder/digital-twin/media pages+hooks (#2682), apps/GitHub/misc (#2721), loras/media (#2723), digital-twin leftovers (#2730), creative director (#2743), meatspace health-forms (#2755).