Repository navigation
Publish through Atlassian's Artifactory - #1
Merged
Merged
Conversation
Keep the changesets release flow, but publish to Artifactory's npm-public repository, which forwards @atlassian/cloudflared to npmjs. Credentials come from atlassian-labs/artifact-publish-token instead of npm trusted publishing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up publishing of
@atlassian/cloudflaredto npmjs through Atlassian's Artifactory. The release flow is the same as before: changesets opens a release PR, and merging it publishes.Changes
package.json: addspublishConfig.registry, which points athttps://packages.atlassian.com/api/npm/npm-public/. Artifactory forwards packages from there to npmjs.release.yml: gets temporary credentials fromatlassian-labs/artifact-publish-token, the same way@atlassian/connect-to-forgedoes. The action writes.npmrc-public, which reads the credentials from environment variables. The workflow moves that file to~/.npmrcsopnpm changeset publishuses it, and so it can't be committed into a release PR. The npm trusted-publishing comments are removed because they no longer apply.The package is on the
npm-publicallow list.There are no pending changesets, so merging runs
changeset publishand releases@atlassian/cloudflared@0.7.3. That is the current upstream code, without the binary-update fix from JacobLinCool#43. The first release also creates the package on npm, which the Artifacts Team needs before it can set up trusted publishing.🤖 Generated with Claude Code