Rollback on failed OXP POST#524
Open
congwang09 wants to merge 17 commits intomainfrom
Open
Conversation
Coverage Report for CI Build 25141820874Coverage decreased (-2.5%) to 50.292%Details
Uncovered Changes
Coverage Regressions14 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
This was referenced Apr 22, 2026
Contributor
|
As discussed on slack and on the weekly meeting, after reviewing this PR and their dependencies, the end-to-end tests are passing. However the mentioned issue #519 (#519) seems still unfixed: we are still seeing the breakdowns on the OXPs after the failure. The expected behavior would be an empty reply from OXP's L2VPN. Cong mentioned that it ca be because of the merging with main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #519
This PR should merge after atlanticwave-sdx/sdx-lc#204 and atlanticwave-sdx/pce#304
If OXP POST request failed, or timeout, roll back partially provisioned connection request