Skip to content

Rollback on failed OXP POST#524

Open
congwang09 wants to merge 17 commits intomainfrom
rollback-on-failed-oxp-post
Open

Rollback on failed OXP POST#524
congwang09 wants to merge 17 commits intomainfrom
rollback-on-failed-oxp-post

Conversation

@congwang09
Copy link
Copy Markdown
Contributor

@congwang09 congwang09 commented Apr 9, 2026

Resolves: #519
This PR should merge after atlanticwave-sdx/sdx-lc#204 and atlanticwave-sdx/pce#304

If OXP POST request failed, or timeout, roll back partially provisioned connection request

@congwang09 congwang09 marked this pull request as draft April 9, 2026 15:07
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 9, 2026

Coverage Report for CI Build 25141820874

Coverage decreased (-2.5%) to 50.292%

Details

  • Coverage decreased (-2.5%) from the base build.
  • Patch coverage: 256 uncovered changes across 5 files (106 of 362 lines covered, 29.28%).
  • 14 coverage regressions across 4 files.

Uncovered Changes

File Changed Covered %
sdx_controller/handlers/connection_handler.py 158 62 39.24%
sdx_controller/handlers/lc_message_handler.py 90 4 4.44%
sdx_controller/controllers/l2vpn_controller.py 66 9 13.64%
sdx_controller/init.py 47 31 65.96%
sdx_controller/messaging/rpc_queue_consumer.py 1 0 0.0%

Coverage Regressions

14 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
sdx_controller/handlers/connection_handler.py 5 57.98%
sdx_controller/controllers/l2vpn_controller.py 4 41.56%
sdx_controller/utils/db_utils.py 4 77.27%
sdx_controller/handlers/lc_message_handler.py 1 9.89%

Coverage Stats

Coverage Status
Relevant Lines: 2742
Covered Lines: 1379
Line Coverage: 50.29%
Coverage Strength: 1.01 hits per line

💛 - Coveralls

@italovalcy
Copy link
Copy Markdown
Contributor

As discussed on slack and on the weekly meeting, after reviewing this PR and their dependencies, the end-to-end tests are passing. However the mentioned issue  #519 (#519) seems still unfixed: we are still seeing the breakdowns on the OXPs after the failure. The expected behavior would be an empty reply from OXP's L2VPN. Cong mentioned that it ca be because of the merging with main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect behavior for Use Case 4: OXP failed to install L2VPN

4 participants