Add an option to plot virtual memory instead of real memory#23
Open
na-ka-na wants to merge 1 commit intoastrofrog:mainfrom
Open
Add an option to plot virtual memory instead of real memory#23na-ka-na wants to merge 1 commit intoastrofrog:mainfrom
na-ka-na wants to merge 1 commit intoastrofrog:mainfrom
Conversation
Author
astrofrog
reviewed
Feb 14, 2018
psrecord/main.py
Outdated
| ax2.plot(log['times'], log['mem_real'], '-', lw=1, color='b', label='real') | ||
| if plot_virtual_memory: | ||
| ax2.plot(log['times'], log['mem_virtual'], '-', lw=1, color='g', label='virt') | ||
| ax2.set_ylim(0., max(log['mem_virtual']) * 1.2) |
Owner
There was a problem hiding this comment.
Could you fix the indentation here to use four spaces instead of two?
Owner
|
Thanks for the pull request! Just a small comment above. |
Author
|
Fixed the indentation, thanks! |
astrofrog
requested changes
Jun 16, 2018
Owner
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
@na-ka-na - thanks! To keep the plot de-cluttered, I think it might be nicer to get rid of the legends and instead for the y axis on the right we can write e.g.:
Real and Virtual memory
and color code the words according to the lines. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.