fix: honor disable_numparse when wrapping thousands-separated cells - #449
Open
BlocksecPHD wants to merge 1 commit into
Open
fix: honor disable_numparse when wrapping thousands-separated cells#449BlocksecPHD wants to merge 1 commit into
BlocksecPHD wants to merge 1 commit into
Conversation
_wrap_text_to_colwidths passed numparse as the has_invisible argument of _type, so disable_numparse was ignored. Combined with int() on strings like "100,120", wrapping raised ValueError (github issue astanin#448).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_wrap_text_to_colwidthscalled_type(cell, numparse), which bound the flag tohas_invisibleand leftnumparse=True.disable_numparsewas therefore ignored while wrapping.100,120are typed asintbut cannot be constructed withint(); fall back tostr(cell)when that conversion fails.Test plan
pyteston Python 3.11: 325 passed, 60 skipped100,120with and withoutdisable_numparse=True