Capture names as full paths #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogseth
force-pushed
the
full-path-names
branch
from
bb9458e to
384bd95
Compare
Note that the list of passing tests is 1, even though 2 tests have passed. Probably because they both share the exact same test name: `foo`.
Regarding the bug shown visible in the test in the previous commit, where two passing tests both named `foo` would give output that only 1 test passed: The test macros should now always give unique names to all tests, so this is no longer visible when using the macros. However, unique test names is noo guaranteed when using the imperative API, so the bug could still happen (just not when using the macros).
Pull Request Test Coverage Report for Build 20302849194Details
💛 - Coveralls |
skogseth
force-pushed
the
full-path-names
branch
from
384bd95 to
b6e63d8
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests emitted by rustc use the full path, not including the crate name, as the name for the test (impl). From what I can tell there's no way to get this path exactly from rust, but we can get the full path including crate name from
std::module_path. We can then find the first occurence of::and grab whatever follows.Fixes #154.