test(analyze): cover unstable onRouteChange calls - #51
Closed
lntutor wants to merge 2 commits into
Closed
Conversation
lntutor
force-pushed
the
fix/on-route-change-analysis
branch
from
July 31, 2026 01:25
06a108e to
9b6667c
Compare
Contributor
Author
|
Rebased onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onRouteChange()callsaskr/stable-render-callContext
The catalog fix from issue #41 was merged in #58 while this PR was open. That merge added
onRouteChangeto the lifecycle catalog but did not retain focused coverage for the rule behavior. This rebased PR now contains only that missing regression test.Validation
npm run check: lint, typecheck, 202 tests with coverage, build, publint, and package dry-run