Skip to content

test(analyze): cover unstable onRouteChange calls - #51

Closed
lntutor wants to merge 2 commits into
askrjs:mainfrom
lntutor:fix/on-route-change-analysis
Closed

test(analyze): cover unstable onRouteChange calls#51
lntutor wants to merge 2 commits into
askrjs:mainfrom
lntutor:fix/on-route-change-analysis

Conversation

@lntutor

@lntutor lntutor commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add focused regression coverage for module-scope onRouteChange() calls
  • cover conditional component calls through askr/stable-render-call
  • assert both diagnostics remain errors

Context

The catalog fix from issue #41 was merged in #58 while this PR was open. That merge added onRouteChange to the lifecycle catalog but did not retain focused coverage for the rule behavior. This rebased PR now contains only that missing regression test.

Validation

  • full npm run check: lint, typecheck, 202 tests with coverage, build, publint, and package dry-run

@lntutor
lntutor requested a review from smiggleworth as a code owner July 30, 2026 13:18
@lntutor
lntutor force-pushed the fix/on-route-change-analysis branch from 06a108e to 9b6667c Compare July 31, 2026 01:25
@lntutor lntutor changed the title fix(analyze): flag unstable onRouteChange calls test(analyze): cover unstable onRouteChange calls Jul 31, 2026
@lntutor

lntutor commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current main after #58 merged. The implementation is already upstream, so this PR now contains only the missing focused regression coverage for module-scope and conditional onRouteChange() calls. The full repository check passes (202 tests, lint, typecheck, coverage, build, publint, package dry-run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants