Skip to content

chore: let the booking's guest range be empty - #820

Merged
zachdaniel merged 1 commit into
ash-project:mainfrom
matt-beanland:fix/booking-allows-an-empty-range
Aug 18, 2026
Merged

chore: let the booking's guest range be empty#820
zachdaniel merged 1 commit into
ash-project:mainfrom
matt-beanland:fix/booking-allows-an-empty-range

Conversation

@matt-beanland

@matt-beanland matt-beanland commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Contributor checklist

  • I accept the AI Policy, or AI was not used in the creation of this PR.
  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

Closes #819

In fixture allow_empty?: true

Needs an unreleased ash: Ash.Type.Range and its allow_empty? constraint are not in
v3.31.3, and CI here takes ash from hex, so this will be red until the next release.

The fixture already depends on the unreleased type — attribute(:guests, :range) does not
compile against v3.31.3 either — so this only extends that dependency to the constraint.

@zachdaniel
zachdaniel merged commit aa41781 into ash-project:main Aug 18, 2026
115 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Booking's range test fails against ash main: an empty range is refused

2 participants