Expose generic eval runtime#6
Conversation
|
That PR is merged, not sure what this changes (or really why, as the description is light on that context), can you pull into this branch? |
|
I thought there was a dependency but I can't find it now, so to be honest I am not quite sure what I meant :S |
| end | ||
|
|
||
| defp eval_manifest_cache_enabled? do | ||
| :persistent_term.get(@eval_manifest_cache_enabled_key, false) |
There was a problem hiding this comment.
Why do we need to check in persistent term if it's enabled? I think we could just have like a cache?: true option when generating these. EvalActions would then do it by default (good idea).
There was a problem hiding this comment.
I had my backwards compatible hat on for the most part. I'd be happy to change it to just be the default. I havent used persistent term a lot, not sure if there were wider ramifications.
Summary
AshLua.Evalas a generic runtime API for manifest resolution, docs, and script executionpreload_eval_manifests!/1Checks
mix deps.getmix compileMIX_ENV=test mix testmix check --no-retryBuilds on #5; once that merges, this PR should reduce to the follow-up eval/runtime commit.