fix: support multiple audiences in ID token validation#382
Open
dileepapeiris wants to merge 4 commits intoasgardeo:mainfrom
Open
fix: support multiple audiences in ID token validation#382dileepapeiris wants to merge 4 commits intoasgardeo:mainfrom
dileepapeiris wants to merge 4 commits intoasgardeo:mainfrom
Conversation
Change audience parameter from string to array in jose.jwtVerify() to properly validate tokens with multiple audiences (e.g., Choreo tokens with ['client-id', 'choreo:deployment:sandbox']). This fixes validation failures that caused immediate logout after authentication."
Change audience parameter from string to array in jose.jwtVerify() to properly validate tokens with multiple audiences (e.g., Choreo tokens with ['client-id', 'choreo:deployment:sandbox']). This fixes validation failures that caused immediate logout after authentication."
Change audience parameter from string to array in jose.jwtVerify() to properly validate tokens with multiple audiences (e.g., Choreo tokens with ['client-id', 'choreo:deployment:sandbox']). This fixes validation failures that caused immediate logout after authentication."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes ID token validation failure when tokens contain multiple audiences.
Problem:
audclaim (e.g.,["client-id", "additional-audience"])audience: clientId(string) tojose.jwtVerify()Solution:
Changed the
audienceparameter from string to array in all crypto-utils files:audience: clientIdaudience: [clientId]This allows jose to properly validate tokens with single or multiple audiences.
Related Issues
Related PRs
Checklist
Security checks