Merged
Conversation
florindragos
force-pushed
the
docs
branch
2 times, most recently
from
a5e0e08 to
306f505
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces documentation updates for Okta and Entra ID integration and modifies the SCIM-related tests and conversion logic to support base64-encoded IDs for handling whitespaces. Key changes include:
- Updating test cases in pkg/test/scim_test.go to use dynamic IDs returned from create endpoints.
- Renaming functions and modifying transformation calls across user and group handlers and converter functions to incorporate base64 encoding.
- Enhancing documentation in the docs folder and updating configuration and template loading in the application.
Reviewed Changes
Copilot reviewed 18 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/test/scim_test.go | Updated test cases to retrieve IDs dynamically and validate responses using base64 IDs. |
| pkg/test/assets/assets.go | Added group asset and renamed Patch function to PatchOp to support new testing logic. |
| pkg/config/config.go | Introduced TemplateFile to allow custom template configuration. |
| pkg/app/run.go | Added logic to load a template file if specified. |
| docs/okta.md & docs/entra-id.md | Added and updated documentation for Okta and Entra ID SCIM integration. |
| common/handlers/* (users/groups) | Updated transformation calls by passing dynamic IDs rather than hardcoded values. |
| common/convert/* | Updated conversion functions and tests to use base64 encoded IDs. |
| common/assets.go | Modified the default template loader to support the new transform configuration. |
| README.md | Updated provisioning documentation and clarified relation mappings. |
Files not reviewed (5)
- common/assets/template.tmpl: Language not supported
- common/assets/users-groups.tmpl: Language not supported
- common/assets/users.tmpl: Language not supported
- pkg/test/assets/data/morty.json: Language not supported
- pkg/test/assets/data/rick.json: Language not supported
Contributor
|
edit: it doesn't. my mistake |
ronenh
approved these changes
Apr 29, 2025
Contributor
ronenh
left a comment
ronenh
left a comment
There was a problem hiding this comment.
Looks good. Just fix the typos found by Copilot.
Contributor
Author
I did a rebase after squashing the other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use base64 encoded IDs to support any whitespaces