fix(factory): handle explicit tzinfo=None in arrow.get()#1273
Open
armorbreak001 wants to merge 1 commit intoarrow-py:masterfrom
Open
fix(factory): handle explicit tzinfo=None in arrow.get()#1273armorbreak001 wants to merge 1 commit intoarrow-py:masterfrom
armorbreak001 wants to merge 1 commit intoarrow-py:masterfrom
Conversation
When tzinfo=None is explicitly passed to arrow.get(), it was incorrectly treated as 'not provided', causing the factory to route to the 3-arg constructor path which fails for (str, fmt) calls. Use a sentinel to distinguish missing from explicit None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1259.
When
tzinfo=Noneis explicitly passed toarrow.get()(e.g. from a variable that may be None), it was incorrectly treated as 'tzinfo not provided'. This caused the factory to route to the 3-argument constructor path, which fails for calls likearrow.get('2025-01-01', 'YYYY-MM-DD', tzinfo=None)with:Changes
Use a sentinel object to distinguish between
tzinfobeing omitted vs explicitly set toNone. When explicitlyNone, the factory now correctly proceeds through the normal (str, format) parsing path instead of being misrouted to the constructor path.