fix calculation method for new_epoch #468
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes the calculation method for new_epoch in the time manager test to improve test determinism. The change replaces a non-deterministic calculation based on the current time with a fixed offset from the default epoch.
- Changed
new_epochcalculation fromtime.time() - 86400 * 30toTMGR_DEFAULT_UNIXTIME_EPOCH_FOR_UTL + 86400 * 30 - Updated the comment to accurately reflect the new calculation method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
FSW 側で ti の値がオーバーフローしない様に、new_epoch の値を小さくする
Issue
検証結果
補足