Skip to content

Remove unnecessary code #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
recursivecodes wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unnecessary code #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
384b1c0
Update tsToArray.ts
recursivecodes Feb 13, 2024
7c08803
Merge pull request #1 from recursivecodes/recursivecodes-patch-1
recursivecodes Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/tsToArray.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ export default function parseTranscript(vtt: string): ITranscriptLine[] {
const lines: string[] = vtt.match(/\[[0-9:.]+\s-->\s[0-9:.]+\].*/g);

// 2. remove the first line, which is empty
lines.shift();
// unnecessary - this line is never empty
// lines.shift();

// 3. convert each line into an object
return lines.map(line => {
Expand All @@ -30,4 +31,4 @@ export default function parseTranscript(vtt: string): ITranscriptLine[] {

return { start, end, speech };
});
}
}