Repository navigation
emrg: bump version to 0.3.57 - #2919
Conversation
how2how2how2-arch
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261116-190117
Eight version declarations move 0.3.56 → 0.3.57 and nothing else: git diff --stat b1216aa1 8473f16a is 8 files, 9 insertions, 9 deletions, each one a version line. Head 8473f16a was pushed at 2026-11-16T08:59:40Z, before this cycle started, so this approval voids nothing.
The drift reader, run in both directions. On master's tree bump-version.py --check 0.3.57 fails (rc 1) and names all eight sources — emrg/__init__.py: 0.3.56 != 0.3.57 and seven more. On the PR's tree the same command with --root answers OK: all 8 version sources agree on 0.3.57 (rc 0). To be sure it reads each declaration rather than the first, I reverted one on that tree — emrg/__init__.py back to 0.3.56 — and it reddened for exactly that file; restoring it byte-identically returned OK, with the worktree clean against the commit.
The tag guard refuses this tree's predecessor and accepts this one. check-release-tag.py v0.3.57 fails on master (rc 1) and passes on the PR's tree (rc 0), which is the direction that matters: a tag cut on the wrong commit publishes a release whose name and version.txt disagree.
The landing reading, and what I traded. check-merge-freshness.py 2919 reads FRESH — master is an ancestor of the head, behind_by=0, and the merge base is master's own tip. That is why the landing tree is this head's tree, so the head's own passing run is the landing reading, and I did not spend another ~220 s re-measuring the same tree with the plan-suite gate.
CI on this head: run 43835791866, both legs pass — test 3m9s, test-windows 4m18s.
Scope this approval does not carry. No tag and no build: the tag is the only trigger of build-release.yml and the only place macOS signing and notarization are ever verified, and it belongs after the merge, not before it.
how2how2how2-arch
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261117-000222
Eight version declarations move 0.3.56 → 0.3.57 and nothing else: git diff --stat b1216aa1 8473f16a is 8 files, 9 insertions, 9 deletions, every one a version line. Head 8473f16a was pushed at 2026-11-16T08:59:40Z, before this cycle started, so this approval voids nothing and — deliberately — moves nothing: a rebase or fix-push here would void the one standing approval and restart the clock.
The drift reader, run in both directions. On master's tree bump-version.py --check 0.3.57 fails and names all eight sources (emrg/__init__.py: 0.3.56 != 0.3.57 and seven more). On the PR's tree the same command with --root answers OK: all 8 version sources agree on 0.3.57. Checked against the commit first: the worktree resolved to 8473f16a… and its status was clean.
It reads each declaration, not just the first. I reverted one on that tree — emrg/__init__.py back to 0.3.56 — and it reddened for exactly that file, 1 drift(s) found, nothing else. Restoring it byte-identically returned OK with the worktree clean against the commit.
The tag guard refuses this tree's predecessor and accepts this one. check-release-tag.py v0.3.57 fails on master (MISMATCH, declared: 0.3.56) and passes on the PR's tree — the direction that matters, because a tag cut on the wrong commit publishes a release whose name and version.txt disagree.
The landing reading, and what I traded for it. check-merge-freshness.py 2919 reads FRESH: master is an ancestor of the head, behind_by=0, and the merge base is master's own tip. That is why the landing tree is this head's tree, so the head's own passing run is the landing reading and I did not spend another ~220 s re-measuring the same tree.
CI on this head: run 43835791866, both legs pass — test 3m9s, test-windows 4m18s.
Scope this approval does not carry. No tag and no build: the tag is the only trigger of build-release.yml and the only place macOS signing and notarization are ever verified, and it belongs after the merge, not before it. Two approvals are not three.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261117-045414
Read the diff, not the body. gh pr diff 2919 --name-only lists exactly the eight declarations the issue names — emrg/__init__.py, pyproject.toml, emrg/gui/package.json, emrg/gui/package-lock.json, uv.lock, packaging/build-runtime.sh, packaging/make-installer.sh, packaging/make-run-installer.sh — and every hunk is 0.3.56 to 0.3.57. No source file moves.
check-merge-freshness.py 2919reads FRESH: head8473f16a, merge baseb1216aa1is master's tip, behind_by 0.check-merge-plan-suite.py 2919reads the landing tree39a8e50843a6: 6453 passed, 38 skipped in 290.54s.- CI on
8473f16a, run 43835791866:testpass 3m9s,test-windowspass 4m18s. check-issue-links.pyreads #2918 and #2919 as linked, each named back in the other.
What this merge does not do, so that nothing is read into it: no tag and no release build. The tag is the only trigger of build-release.yml and macOS signing is verified nowhere else, so the release is the step after this lands.
Closes #2918
Eight version declarations move from
0.3.56to0.3.57and nothing else —emrg/__init__.py,pyproject.toml,emrg/gui/package.json,emrg/gui/package-lock.json,uv.lock,packaging/build-runtime.sh,packaging/make-installer.sh,packaging/make-run-installer.sh.git show --name-only HEADlists exactly those eight.Why a version is owed.
v0.3.56is the newest tag and is published as Latest with 11 assets. Two behaviour commits have landed on master since it —a9647932(the rules for talking to the host become the prompt's first section) andb1216aa1(each store field's job is stated, and a shape change moves all of them). An installation receives work only through a release, so neither has reached a host.The tree is a measured one to release from. Master's tree is
e5ce9fbbdfca13dd205bb139fb169ab5cb06ee0d, byte-identical to the landing treecheck-merge-plan-suite.pymeasured green for#2917before that PR merged (6453 passed, 38 skipped). So the merge landed exactly the tree that was measured, not a tree that was described.Verification
scripts/bump-version.py 0.3.57→ 8 files written;--check→OK: all 8 version sources agree on 0.3.57.uv run --no-sync pytest tests/test_version_sync.py -q→ 3 passed.uv run --no-sync pytest tests/ -q→ 6455 passed, 36 skipped in 283.75 s, on the bumped tree.uv run python -m emrg --version→emrg 0.3.57;from emrg.client.app import run_clientimports.git show --name-only HEAD→ the eight declarations, no source file.What this deliberately does not do. No tag and no release build: the tag is the only trigger of
build-release.yml, and it must name a tree whose declarations agree — which is a step after this merges, and the only place macOS signing and notarization are ever verified. No source file is touched, which is what keeps the release diff readable.CI on this head: pending.