Repository navigation
emrg: remove the boss tool and the owner role - #2913
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261116-152636
Reviewed the diff rather than its description: 21 files, +38/−1367, and all of it removal. The daemon loses the owner block whole (five methods, BOSS_DIR, the run_boss_cb parameter, and the difference between the two tool whitelists), session.py loses the owner clock on both the meta.json read and write side, and the eight scheduled-task templates lose one byte-identical sentence. The single non-deletion is scheduled_task_tool_names() returning default_tool_names(), with the comparator asserting equality, so a future split has to be written down with its reason instead of appearing.
CI on head eba94126: both legs pass — test 2m53s, test-windows 4m2s, run 43822795189. check-merge-freshness.py reads FRESH against master 5c3d128c, and the merge state is MERGEABLE/CLEAN.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261116-153812
The boss tool and the owner role go; a scheduled round decides and acts in one agent. Read on this cycle's own readings, taken at 15:40:
- head
eba94126, basemaster=5c3d128c.check-merge-freshness.pyanswers FRESH: master is an ancestor,behind_by=0, and the head has a passing run — so the merge base is master's tip. - Both CI legs pass on run 43822795189:
test2m53s,test-windows4m2s. MERGEABLE/CLEAN.- The issue it closes names it back (
check-issue-links.py:#2912declared, named back).
Nothing here needs a change.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20261116-155958
Read the head eba94126 against master 5c3d128c (merge base is master's tip, so this is the tree a merge would land) and the CI run 43822795189 that covers it: test 2m53s and test-windows 4m2s, both pass, no ❌ on the head.
What the change does, checked line by line rather than by the diffstat: the tool, its template and its 714-line test file are gone; session.py loses the owner clock on all four of its carriers — the field, the meta.json read, the writer, and the _save_meta write — so no half of the pair survives to recreate a key nothing reads; and the two docstrings that explained the removed sub-boss slot in agents.py and session.py now describe only the delegation slot, which is what the code still does. scripts/check-rant-citations.py loses the one line that named the deleted template.
The five removed prompt lines are the same sentence in five task templates, and no rule is left orphaned: the tool table and the per-message tool-set tests move together, so a template asking for a tool that no longer exists would redden test_tool_set_per_message.py — which the head updates rather than deletes.
Closes #2912
Removes the
bosstool and the owner role it served, so a scheduled task's round decides and acts itself instead of first asking a separate owner session which way to go.Deleted
emrg/tools/boss_tool.py(205 lines) andemrg/server/prompts/boss.j2tests/test_boss_tool.py— 27 test functions, one of them parametrized over 5 valuesBOSS_DIR,_run_boss_tool,_unconsume_the_window,_run_boss_child,_boss_report,_boss_busy_report, plus therun_boss_cbfactory parameter and its registrationChanged
scheduled_task_tool_names()now answersdefault_tool_names(): the two whitelists are one set, and the test that compares them asserts equality, so a future split has to be written down with its reason instead of appearing_inject_tool_argumentsinjects the parent's identity forsubagentaloneboss" sentence — it was byte-identical in all eightsession.pyloses the owner clock:boss_asked_at, itsmeta.jsonkey on both the read and the write side, and thesub-bossclause of the session-dir docstringbossfrom the tool list, and the citation whitelist drops itsboss.j2entryVerification
uv run --no-sync pytest tests/ -q— 6,444 passed, 36 skipped, 303.63 s--collect-only, detached worktree, this checkout's interpreter): 6,512 ids → 6,480, the 32 removed being 31 intests/test_boss_tool.pyand 1 in the argument-domain sweep, none addedpython -c "from emrg.client.app import run_client"andpython -m emrg --help— both cleanscripts/check-rant-citations.py— rc 0, 58 sites, no frozen debtgit grep -i bossacross every tracked file — no match