Skip to content

emrg: remove the boss tool and the owner role - #2913

Merged
argszero merged 1 commit into
masterfrom
feature/remove-boss-tool
Nov 16, 2026
Merged

argszero merged 1 commit into
masterfrom
feature/remove-boss-tool

Conversation

@argszero

@argszero argszero commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Closes #2912

Removes the boss tool and the owner role it served, so a scheduled task's round decides and acts itself instead of first asking a separate owner session which way to go.

Deleted

  • emrg/tools/boss_tool.py (205 lines) and emrg/server/prompts/boss.j2
  • tests/test_boss_tool.py — 27 test functions, one of them parametrized over 5 values
  • the daemon's owner block: BOSS_DIR, _run_boss_tool, _unconsume_the_window, _run_boss_child, _boss_report, _boss_busy_report, plus the run_boss_cb factory parameter and its registration

Changed

  • scheduled_task_tool_names() now answers default_tool_names(): the two whitelists are one set, and the test that compares them asserts equality, so a future split has to be written down with its reason instead of appearing
  • _inject_tool_arguments injects the parent's identity for subagent alone
  • the eight scheduled-task prompt templates lose the "the round's first step is to call boss" sentence — it was byte-identical in all eight
  • session.py loses the owner clock: boss_asked_at, its meta.json key on both the read and the write side, and the sub-boss clause of the session-dir docstring
  • both READMEs drop boss from the tool list, and the citation whitelist drops its boss.j2 entry

Verification

  • uv run --no-sync pytest tests/ -q — 6,444 passed, 36 skipped, 303.63 s
  • collection diff against master's own collection (--collect-only, detached worktree, this checkout's interpreter): 6,512 ids → 6,480, the 32 removed being 31 in tests/test_boss_tool.py and 1 in the argument-domain sweep, none added
  • python -c "from emrg.client.app import run_client" and python -m emrg --help — both clean
  • scripts/check-rant-citations.py — rc 0, 58 sites, no frozen debt
  • git grep -i boss across every tracked file — no match

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle cyc20261116-152636

Reviewed the diff rather than its description: 21 files, +38/−1367, and all of it removal. The daemon loses the owner block whole (five methods, BOSS_DIR, the run_boss_cb parameter, and the difference between the two tool whitelists), session.py loses the owner clock on both the meta.json read and write side, and the eight scheduled-task templates lose one byte-identical sentence. The single non-deletion is scheduled_task_tool_names() returning default_tool_names(), with the comparator asserting equality, so a future split has to be written down with its reason instead of appearing.

CI on head eba94126: both legs pass — test 2m53s, test-windows 4m2s, run 43822795189. check-merge-freshness.py reads FRESH against master 5c3d128c, and the merge state is MERGEABLE/CLEAN.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle cyc20261116-153812

The boss tool and the owner role go; a scheduled round decides and acts in one agent. Read on this cycle's own readings, taken at 15:40:

  • head eba94126, base master = 5c3d128c. check-merge-freshness.py answers FRESH: master is an ancestor, behind_by=0, and the head has a passing run — so the merge base is master's tip.
  • Both CI legs pass on run 43822795189: test 2m53s, test-windows 4m2s.
  • MERGEABLE/CLEAN.
  • The issue it closes names it back (check-issue-links.py: #2912 declared, named back).

Nothing here needs a change.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle cyc20261116-155958

Read the head eba94126 against master 5c3d128c (merge base is master's tip, so this is the tree a merge would land) and the CI run 43822795189 that covers it: test 2m53s and test-windows 4m2s, both pass, no ❌ on the head.

What the change does, checked line by line rather than by the diffstat: the tool, its template and its 714-line test file are gone; session.py loses the owner clock on all four of its carriers — the field, the meta.json read, the writer, and the _save_meta write — so no half of the pair survives to recreate a key nothing reads; and the two docstrings that explained the removed sub-boss slot in agents.py and session.py now describe only the delegation slot, which is what the code still does. scripts/check-rant-citations.py loses the one line that named the deleted template.

The five removed prompt lines are the same sentence in five task templates, and no rule is left orphaned: the tool table and the per-message tool-set tests move together, so a template asking for a tool that no longer exists would redden test_tool_set_per_message.py — which the head updates rather than deletes.

@argszero
argszero merged commit 3b9a8fc into master Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emrg: the boss tool goes, and a scheduled round decides and acts in one agent

1 participant