Avoid unnecessary indirection in xml2 usage #551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Have you tested this using the version of xml2 in ADSupport? You can just set XML2_EXTERNAL=NO in areaDetector/configure, and then it will use the version in ADSupport. |
Contributor
Author
|
@MarkRivers Thanks Mark! I do remember that tip and I haven't. I'm trying to adapt Jeung Han Lee's EPICS docker files for Rocky 10. He doesn't use ADSupport. I might do that in the short term still, but I wanted to let you know so ADCore can get ahead of this update. |
Member
|
I just tested your changes on Linux and Windows using the version of xml2 in ADSupport. They both compiled fine, so I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding is that xmlFree has always been part of the public api of libxml2. However, xmlGetGlobalState has since been removed in recent versions. This PR modifies xml2 usage according to these changes.
I made this observation from Rocky 10 and libxml2 2.12.5