fix(api): allow missing required variable when a brick is added #74
+41
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #68
When a brick with required variables is added to an app created from scratch the operation fails.
This is because the FE (appLab) does not pass the required variables when the
PUT /v1/apps/{appID}/bricks/{brickID}is called.If the request body does not contain a value for a required variable, the operation fails.
Additionally, the issue is not present when an app is cloned.
This is because a cloned app already has the
arduino:arduino_cloudbrick configured in theapp.yaml. In this scenario, the FE manages the required variables correctly by asking the users to fill in the required variables.Change description
Do not fail with an error, but log a Warning and put the required variable as an empty string
Additional Notes
Reviewer checklist
main.