fix(update): return better errors #62
Open
+200
−131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should improve the errors returned during the update operation, allowing the caller to be able to understand what happened and if to retry
Change description
codefield in the error structure, both in normal HTTP calls and in SSE ones, with a set of easy-to-match stringsThe error codes for now are:
NO_INTERNET_CONNECTIONOPERATION_IN_PROGRESSUNKNOWN_ERRORBoth
NO_INTERNET_CONNECTIONandOPERATION_IN_PROGRESScould be considered retryable errors.Additional Notes
Reviewer checklist
main.