Improve the arduino-app-cli version command by adding the "server version" #31 #49

martacarbone · 2025-11-06T07:56:06Z

Motivation

When running arduino-app-cli version instead of only returning the version of the currently run executable (the CLI) we should also return the version of the server (the daemon/service running and waiting for HTTP API requests).

Change description

This change make a version request to the running daemon and adds the output to the arduino-app-cli version command.
It also adds "daemon_version" and rename "appName" to "name" from the json output.

Additional Notes

Test done with a daemon with version 8.8.8-server-dev running on port 8080. The output is:

% ./arduino-app-cli version
Warning: cannot get the running daemon version on localhost:8800

Arduino App CLI version 0.0.0-dev

% ./arduino-app-cli version --port 8080
Arduino App CLI version 0.0.0-dev
daemon version: 8.8.8-server-dev

./arduino-app-cli version --format=json 
{
  "name": "Arduino App CLI",
  "version": "0.0.0-dev",
  "warnings": [
    "Warning: cannot get the running daemon version on localhost:8800\n"
  ]
}

% ./arduino-app-cli version --port 8080 --format=json
{
  "name": "Arduino App CLI",
  "version": "0.0.0-dev",
  "daemon_version": "8.8.8-server-dev"
}

./arduino-app-cli version  --port 1234 
Warning: cannot get the running daemon version on localhost:1234

Arduino App CLI version 0.0.0-dev

The http server part is unaffected:

% curl http://localhost:8080/v1/version
{"version":"8.8.8-server-dev"}

Reviewer checklist

PR addresses a single concern.
PR title and description are properly filled.
Changes will be merged in main.
Changes are covered by tests.
Logging is meaningful in case of troubleshooting.

CLAassistant · 2025-11-06T07:56:14Z

All committers have signed the CLA.

lucarin91

Looks good, I added some minor suggestions to make it more readable (in my opinion)

cmd/arduino-app-cli/version/version.go

dido18

I would rename the serverVersion into daemonVersion all over the place

cmd/arduino-app-cli/version/version_test.go

cmd/arduino-app-cli/version/version.go

dido18 · 2025-11-10T08:01:50Z

cmd/arduino-app-cli/version/version.go

+	return net.JoinHostPort(h, p), nil
+}
+
+func getServerVersion(httpClient http.Client, url string) string {


It could be useful to log DEBUG/WARN message with the error of this check.

Proposal:
The function returns a string, error.
If there is an error, the caller logs it, assigns the "empty" daemon version and prints a generic "error on get daemon version" in the cli response.

dido18 · 2025-11-10T08:03:11Z

cmd/arduino-app-cli/version/version.go

+	}
+
+	if daemonVersion == "" {
+		return result, fmt.Errorf("cannot connect to %s", hostAndPort)


This hardcoded error could be misleading if it's not a connection error.
See the proposal to return the error and log it in the comment below

dido18 · 2025-11-10T08:21:50Z

cmd/arduino-app-cli/version/version.go

-	AppName string `json:"appName"`
-	Version string `json:"version"`
+	Name          string `json:"name"`
+	ClientVersion string `json:"client_version"`


This client_version is a breaking change in the JSON response.

Current:

GET http://127.0.0.1:8800/v1/version { "version":"v0.2.3" }

Proposal: leave the version and add the name and daemon_version

GET http://127.0.0.1:8800/v1/version { "name": "Arduino App CLI", "version":"v0.2.3" "daemon_version": "v0.2.3" }

lucarin91 · 2025-11-07T17:22:40Z

cmd/arduino-app-cli/version/version.go

+	serverMessage := fmt.Sprintf("%s client version %s",
+		ProgramName, r.ClientVersion)


Suggested change

serverMessage := fmt.Sprintf("%s client version %s",

ProgramName, r.ClientVersion)

serverMessage := fmt.Sprintf("%s client version %s", ProgramName, r.ClientVersion)

lucarin91 · 2025-11-07T17:23:02Z

cmd/arduino-app-cli/version/version.go

+		serverMessage = fmt.Sprintf("%s\ndaemon version: %s",
+			serverMessage, r.DaemonVersion)


Suggested change

serverMessage = fmt.Sprintf("%s\ndaemon version: %s",

serverMessage, r.DaemonVersion)

serverMessage = fmt.Sprintf("%s\ndaemon version: %s", serverMessage, r.DaemonVersion)

lucarin91 · 2025-11-07T17:23:39Z

cmd/arduino-app-cli/version/version_test.go

+
+// Leverage the http.Client's RoundTripper
+// to return a canned response and bypass network calls.
+type Tripper func(*http.Request) (*http.Response, error)


I usually prefer using the httptest module instead of mocking the http client

cmd/arduino-app-cli/version/version.go

lucarin91 · 2025-11-11T08:57:17Z

cmd/arduino-app-cli/version/version.go

+		resultMessage = fmt.Sprintf("%s\ndaemon version: %s",
+			resultMessage, r.DaemonVersion)


nit

Suggested change

resultMessage = fmt.Sprintf("%s\ndaemon version: %s",

resultMessage, r.DaemonVersion)

resultMessage = fmt.Sprintf("%s\ndaemon version: %s", resultMessage, r.DaemonVersion)

cmd/arduino-app-cli/version/version.go

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

martacarbone added 2 commits November 6, 2025 10:07

Add the server version to arduino-app-cli version.

fd939c5

Add copyright header.

466245c

martacarbone force-pushed the cli_server_version branch from 7484347 to 466245c Compare November 6, 2025 09:14

lucarin91 reviewed Nov 6, 2025

View reviewed changes

Address review comments.

bf435c6

per1234 added the enhancement New feature or request label Nov 8, 2025

Fix lint.

a5d95ea

dido18 requested changes Nov 10, 2025

View reviewed changes

dido18 reviewed Nov 10, 2025

View reviewed changes

dido18 linked an issue Nov 10, 2025 that may be closed by this pull request

Improve the arduino-app-cli version command by adding the "server version" #31

Open

Address review

776bcca

lucarin91 reviewed Nov 10, 2025

View reviewed changes

Define the port only as custom input.

7aba0e1

lucarin91 reviewed Nov 11, 2025

View reviewed changes

martacarbone and others added 3 commits November 11, 2025 10:59

Update cmd/arduino-app-cli/version/version.go

a9b0ca2

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update cmd/arduino-app-cli/version/version.go

ef78764

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

Update cmd/arduino-app-cli/version/version.go

0f6e212

Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>

lucarin91 approved these changes Nov 11, 2025

View reviewed changes

dido18 approved these changes Nov 11, 2025

View reviewed changes

		serverMessage := fmt.Sprintf("%s client version %s",
		ProgramName, r.ClientVersion)

		serverMessage = fmt.Sprintf("%s\ndaemon version: %s",
		serverMessage, r.DaemonVersion)

		resultMessage = fmt.Sprintf("%s\ndaemon version: %s",
		resultMessage, r.DaemonVersion)

Improve the arduino-app-cli version command by adding the "server version" #31 #49

Are you sure you want to change the base?

Improve the arduino-app-cli version command by adding the "server version" #31 #49

Conversation

martacarbone commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Change description

Additional Notes

Reviewer checklist

Uh oh!

CLAassistant commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lucarin91 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dido18 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dido18 Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

dido18 Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

dido18 Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lucarin91 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

lucarin91 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

lucarin91 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lucarin91 Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

martacarbone commented Nov 6, 2025 •

edited

Loading

CLAassistant commented Nov 6, 2025 •

edited

Loading

dido18 Nov 10, 2025 •

edited

Loading