Skip to content

fix: force app stop also if it isn't running #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
+10 −11
Merged

fix: force app stop also if it isn't running #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions internal/orchestrator/orchestrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,16 +388,6 @@ func stopAppWithCmd(ctx context.Context, docker command.Cli, app app.ArduinoApp,
ctx, cancel := context.WithCancel(ctx)
defer cancel()

appStatus, err := getAppStatus(ctx, docker, app)
if err != nil {
yield(StreamMessage{error: err})
return
}
if appStatus.Status != StatusStarting && appStatus.Status != StatusRunning {
yield(StreamMessage{data: fmt.Sprintf("app %q is not running", app.Name)})
return
}

if !yield(StreamMessage{data: fmt.Sprintf("Stopping app %q", app.Name)}) {
return
}
Expand All @@ -413,7 +403,16 @@ func stopAppWithCmd(ctx context.Context, docker command.Cli, app app.ArduinoApp,
})

if app.MainSketchPath != nil {
// TODO: check that the app sketch is running before attempting to stop it.
// Before stopping the microcontroller we want to make sure that the app was running.
appStatus, err := getAppStatus(ctx, docker, app)
if err != nil {
yield(StreamMessage{error: err})
return
}
if appStatus.Status != StatusStarting && appStatus.Status != StatusRunning {
yield(StreamMessage{data: fmt.Sprintf("app %q is not running", app.Name)})
return
}

if err := micro.Disable(); err != nil {
yield(StreamMessage{error: err})
Expand Down