Skip to content

Conversation

@eigen-value
Copy link
Collaborator

@eigen-value eigen-value commented Oct 30, 2025

This PR addresses a thread related concern: concurrent calls to .result

Besides it introduces a change in the API that breaks backwards compatibility, but improves readability:

// no longer
// RpcResult async_res = Bridge.call("metod", param);
// async_res.result(res);

// after this PR
RpcCall async_call = Bridge.call("metod", param);
async_call.result(res);

fix:
restores read_timeout in tcp_client

fix: RpcCall.result needs thread protected single execution
@eigen-value eigen-value requested a review from facchinm October 30, 2025 07:56
@eigen-value eigen-value linked an issue Oct 30, 2025 that may be closed by this pull request
@per1234 per1234 added the enhancement New feature or request label Oct 30, 2025
@eigen-value eigen-value requested a review from pennam November 14, 2025 17:14
@eigen-value eigen-value marked this pull request as ready for review November 14, 2025 17:19
@github-actions
Copy link

Memory usage change @ 3f06c40

Board flash % RAM for global variables %
arduino:zephyr:unoq 🔺 +548 - +1044 +0.03 - +0.05 0 - 0 0.0 - 0.0
Click for full report table
Board examples/client
flash
% examples/client
RAM for global variables
% examples/clientSSL
flash
% examples/clientSSL
RAM for global variables
% examples/hci
flash
% examples/hci
RAM for global variables
% examples/monitor
flash
% examples/monitor
RAM for global variables
% examples/server
flash
% examples/server
RAM for global variables
% examples/simple_bridge
flash
% examples/simple_bridge
RAM for global variables
% examples/test
flash
% examples/test
RAM for global variables
% examples/udp_ntp_client
flash
% examples/udp_ntp_client
RAM for global variables
%
arduino:zephyr:unoq 852 0.04 0 0.0 984 0.05 0 0.0 624 0.03 0 0.0 548 0.03 0 0.0 876 0.04 0 0.0 712 0.04 0 0.0 792 0.04 0 0.0 1044 0.05 0 0.0
Click for full report CSV
Board,examples/client<br>flash,%,examples/client<br>RAM for global variables,%,examples/clientSSL<br>flash,%,examples/clientSSL<br>RAM for global variables,%,examples/hci<br>flash,%,examples/hci<br>RAM for global variables,%,examples/monitor<br>flash,%,examples/monitor<br>RAM for global variables,%,examples/server<br>flash,%,examples/server<br>RAM for global variables,%,examples/simple_bridge<br>flash,%,examples/simple_bridge<br>RAM for global variables,%,examples/test<br>flash,%,examples/test<br>RAM for global variables,%,examples/udp_ntp_client<br>flash,%,examples/udp_ntp_client<br>RAM for global variables,%
arduino:zephyr:unoq,852,0.04,0,0.0,984,0.05,0,0.0,624,0.03,0,0.0,548,0.03,0,0.0,876,0.04,0,0.0,712,0.04,0,0.0,792,0.04,0,0.0,1044,0.05,0,0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RpcResult improvements

3 participants