Fix bspwm black screen: add provision() delegation and default configs#4518
Open
Softer wants to merge 1 commit intoarchlinux:masterfrom
Open
Fix bspwm black screen: add provision() delegation and default configs#4518Softer wants to merge 1 commit intoarchlinux:masterfrom
Softer wants to merge 1 commit intoarchlinux:masterfrom
Conversation
svartkanin
reviewed
May 4, 2026
|
|
||
| from archinstall.default_profiles.profile import DisplayServerType, GreeterType, Profile, ProfileType | ||
|
|
||
| if TYPE_CHECKING: |
Collaborator
There was a problem hiding this comment.
Why are they behind a type check?
Contributor
Author
There was a problem hiding this comment.
As far as I understand - python 3.14 evaluates annotations lazily (PEP 649), so Installer and User are never resolved at runtime - they're only used by type checkers. TYPE_CHECKING avoids importing heavy modules (Installer pulls in a lot) and sidesteps potential circular imports.
Collaborator
There was a problem hiding this comment.
Are there actual circular deps? If not we shouls define these as regular imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bspwm profile installs packages but does not provision configuration files. After login via lightdm the user sees a black screen with no keybindings because ~/.config/bspwm/bspwmrc and ~/.config/sxhkd/sxhkdrc do not exist.
Two fixes: