fix: force resource name change on scheduled functions since resource type was changed#174
Open
fix: force resource name change on scheduled functions since resource type was changed#174
Conversation
… type was changed
macdonst
approved these changes
Feb 17, 2026
Contributor
macdonst
left a comment
macdonst
left a comment
There was a problem hiding this comment.
Great idea to force the name change. Thanks for taking this one on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes architect/architect#1518.
In #173, we expanded the feature set of scheduled functions, allowing for configuration of timezone. However, this change required a CloudFormation resource
typechange (fromAWS::Events::RuletoAWS::Scheduler::Schedule). However, we did not change the resourcename. Changing resourcetypefor existing resources is not permitted in CloudFormation. For Stacks that were already deployed prior to the change introduced in #173, this led to the error seen in the issue above:This PR addresses this problem by changing the resource
namefor the scheduled event. For existing Stacks, this would force a delete + create operation on deploy. Since the schedule rule and lambda are both stateless, this should be an idempotent operation.