Repository navigation
Conversation
The executor's maintenance pass, which removes idle runtimes, ran every 3600 seconds because the chart hard-coded OPR_EXECUTOR_MAINTENANCE_INTERVAL. Add compute.executor.maintenanceInterval (3600 by default, so the rendered values don't change) and document it, with the tests and the chart README, values.schema.json and changelog entry that go with it.
🟢 Tier S · Ready to merge
Adds
Note @gurkangul does not have write access to this repository, so Hansi does not approve automatically. A maintainer can review and approve. 📂 Walkthrough · 7
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The executor's maintenance pass removes runtimes that have been idle longer than
inactiveThreshold, but the chart hard-codes its interval (OPR_EXECUTOR_MAINTENANCE_INTERVAL: "3600"). With many scheduled functions, idle runtimes can therefore hold memory for up to an hour afterinactiveThresholdhas passed.This adds
compute.executor.maintenanceInterval, defaulting to 3600, so rendered manifests don't change unless it is set. The schema enforces a minimum of 1.templates/executor/deployment.yamlreads the value with the sameappwrite.envValuehelper asinactiveThreshold.make generate;docs/executor.mdand a CHANGELOG entry under Unreleased."3600"; setting 60 renders"60".Checks run locally:
ct lint,helm lint --stricton all CI value sets;make unittest(260 passed);make kubeconform,make examples,make check-generated,make check-changes.