Repository navigation
fix(chart): bump clickhouse to 26.8.36 - #49
Merged
Merged
Conversation
Clears the 26.4 image's high Trivy findings (musl, zlib, OpenSSL). 26.8 is the newest LTS line. ClickHouse 26.7+ marks the system log tables it replaces table_readonly, which made init.sh's MODIFY TTL fail and the upgraded pod exit, so init.sh resets the setting first.
🟢 Tier S · Ready to mergeThis bumps the built-in ClickHouse image from 26.4.5 to 26.8.36 and updates the bundled-image metadata and external-database fixture. It also resets
📂 Walkthrough · 7
🔇 Filtered out · 1Findings Hansi considered but did not post.
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the built-in ClickHouse off the 26.4 line to clear its open Trivy findings (
trivy-image-clickhouse). 26.8 is the newest LTS line after 26.4; 26.8.36 is its newest patch. Appwrite'sdocker-compose.yml(main and 2.7.x) still uses 26.4.3-alpine.clickhouse/clickhouse-server26.4.5-alpine26.8.36-alpineScanned with
trivy image --severity HIGH,CRITICAL --ignore-unfixed --scanners vuln, linux/amd64.Chart change needed: since 26.7, ClickHouse marks the system log tables it replaces (
backup_log_0,s3queue_log_0)table_readonly, soinit.sh'sALTER TABLE ... MODIFY TTLfailed withTABLE_IS_PERMANENTLY_READ_ONLYand the upgraded pod exited.init.shnow emitsRESET SETTING table_readonlybefore the TTL alter for those tables. On 26.4 the branch never fires.Backward-incompatible changes in 26.5–26.8 reviewed
table_readonlyinit.sh; fixed hereX-ClickHouse-FormatoverridesFORMATDateTime64read as Unix timestampsY-m-d H:i:s.vstringsmax_insert_threadsdefaultautoMap/ labelled Prometheus series/metricsendpoint; the chart ships no rules or dashboards on those namesinclude_fromno longer defaults to/etc/metrika.xmlUPDATE; single replicaAggregatingMergeTreerejects non-key dimensionsnew_unified_hashdefaultdate_time_input_format→best_efforthttp_max_fields1000snowflakeToDateTime,kql, KQL array sorts,hasColumnInTableremote),RANK(x),arrayIntersect,toTime,Date32/DateTime64range,EXPLAIN SYNTAX,librarydictionaries, Arrow/Parquet readers, NATS/MySQL TLS pathsUpgrade test (image run like the pod: read-only root, UID 101, all caps dropped, the chart's rendered
config.d/users.d/init.shfrom the hardened scenario mounted):appwriteuser, inserted JSONEachRow rows.init.sh: pod exits (backup_log_0read-only). With thisinit.sh: starts, all rows read back unchanged, new inserts/MV/update work, rotated tables get their TTL.SELECT version()= 26.8.36.3, create/insert/select works, clean restart.The kind install scenarios all run the built-in ClickHouse;
external-dbsuses the bumped fixture.Related: appwrite-labs/cloud#6671