Skip to content

chore: update dependencies #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abnegate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update dependencies #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Pin php:8.5-alpine by multi-arch index digest. Bump with:
# docker buildx imagetools inspect php:8.5-alpine | head -2
ARG BASE_IMAGE="php:8.5-alpine@sha256:4992c6fda82eadfb3b22dca3929188dc5831e9f44a3d42b3c8d36a460b4d5a80"
ARG BASE_IMAGE="php:8.5-alpine@sha256:93684051146ec037620855feb77f278090bde45ddc030801cd3f2a7685bc4deb"

FROM $BASE_IMAGE AS compile

Expand All @@ -17,8 +17,8 @@ ENV \
PHP_LZ4_COMMIT="065a57d8fe237924d74efa3baedf231b7f837c3a" \
PHP_MAXMINDDB_VERSION="v1.14.0" \
PHP_MAXMINDDB_COMMIT="f3c92f68b3bec42a9aa780368399e03dc6b91e89" \
PHP_MONGODB_VERSION="2.5.2" \
PHP_MONGODB_COMMIT="365aabbed6a6ba1f6a126d6c876d87cdf9f61a82" \
PHP_MONGODB_VERSION="2.5.3" \
PHP_MONGODB_COMMIT="3551aa91ec7662ec9f7baa62358b7cda8aa5ae08" \
PHP_PROTOBUF_VERSION="5.36.2" \
PHP_PROTOBUF_CHECKSUM="f0a17c67de29df0fb0e5215a381df9b155125e1ace6252dd617bf16b4194dd5b" \
PHP_REDIS_VERSION="6.3.0" \
Expand All @@ -27,8 +27,8 @@ ENV \
PHP_SCRYPT_COMMIT="5a14bc766423dac3f868792fa8c41f85f47263ec" \
PHP_SNAPPY_VERSION="0.2.3" \
PHP_SNAPPY_COMMIT="d31b77d63955dbbf1a302ca13c4795292f91d140" \
PHP_SWOOLE_VERSION="v6.2.2" \
PHP_SWOOLE_COMMIT="8e8c49915ca5f9dcb9ee654f9e336a9c88dd375e" \
PHP_SWOOLE_VERSION="v6.2.3" \

@greptile-apps greptile-apps Bot Sep 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Swoole bump breaks image test The image now builds Swoole v6.2.3, but tests.yaml still requires php --re swoole to report version 6.2.2. The container structure workflow builds this image and runs that test, so a successful build will still fail the check and block the dependency update. This assertion mirrors a version pin rather than testing Swoole behavior; replace it with an observable compatibility check instead of changing the expected string to 6.2.3.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: Dockerfile
Line: 30

Comment:
**Swoole bump breaks image test** The image now builds Swoole v6.2.3, but `tests.yaml` still requires `php --re swoole` to report version 6.2.2. The container structure workflow builds this image and runs that test, so a successful build will still fail the check and block the dependency update. This assertion mirrors a version pin rather than testing Swoole behavior; replace it with an observable compatibility check instead of changing the expected string to 6.2.3.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

PHP_SWOOLE_COMMIT="8b20cd39f8c19da7aaf70290037e04f616db5ff7" \
PHP_YAML_VERSION="2.3.0" \
PHP_YAML_COMMIT="c1f0d8ba5ef3884846261bbdb91c2ab0b07db44c" \
PHP_ZSTD_VERSION="0.18.0" \
Expand Down
Loading