Skip to content

Fix nameserver verification SDK calls#3095

Merged
ChiragAgg5k merged 2 commits into
mainfrom
fix-domain-nameserver-verification-sdk
Jun 26, 2026
Merged

Fix nameserver verification SDK calls#3095
ChiragAgg5k merged 2 commits into
mainfrom
fix-domain-nameserver-verification-sdk

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

What does this PR do?

Updates the console to match the nameserver API split from appwrite-labs/cloud#4515.

  • Pins @appwrite.io/console to the preview SDK generated from cloud commit d7ff250
  • Replaces domain retry/check flows that previously called domains.updateNameservers() with domains.verifyNameservers()
  • Leaves updateNameservers() reserved for the new explicit registrar delegation update behavior

Test Plan

  • git diff --check
  • bun run check (fails on an existing/preview SDK OAuth typing mismatch: oauth2.approve() no longer types the scope parameter used by src/routes/(public)/oauth2/consent-card.svelte; nameserver call sites type against the preview SDK)

Related PR

  • appwrite-labs/cloud#4515

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR aligns the console with the nameserver API split introduced in the backend (appwrite-labs/cloud#4515), bumping the SDK to commit 0fcb4f2 and replacing all domains.updateNameservers() call sites with domains.verifyNameservers().

  • All 9 affected call sites (across organization, project settings, functions, and sites domain flows) are consistently updated; a grep confirms no stale updateNameservers usages remain in src/.
  • The SDK pin in package.json and bun.lock is updated to the matching preview build; the pre-existing bun run check failure noted in the test plan is an unrelated OAuth typing issue in the preview SDK, not introduced by this PR.

Confidence Score: 5/5

Straightforward method rename across all affected call sites with no logic changes; safe to merge once the backend API split lands.

Every call site that previously called updateNameservers now calls verifyNameservers with the same arguments and return value handling. No logic, error handling, or control flow was altered. The SDK bump is a matching preview build, and the known type error in bun run check is pre-existing and unrelated to the nameserver changes.

No files require special attention; all changes are mechanical and consistent.

Important Files Changed

Filename Overview
package.json SDK dependency bumped from 88cc66d to 0fcb4f2 to pick up the verifyNameservers API split.
bun.lock Lock file updated to match the new SDK commit hash; no other dependency changes.
src/lib/components/domains/viewLogsModal.svelte Replaced updateNameservers with verifyNameservers in the isCloud retry branch.
src/routes/(console)/organization-[organization]/domains/recordsCard.svelte Replaced updateNameservers with verifyNameservers; domain verification logic otherwise unchanged.
src/routes/(console)/organization-[organization]/domains/retryDomainModal.svelte Replaced updateNameservers with verifyNameservers in the retry flow.
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/verify-[domain]/+page.svelte Replaced updateNameservers with verifyNameservers in the add-domain verification page for functions.
src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/retryDomainModal.svelte Replaced updateNameservers with verifyNameservers in the functions domain retry modal.
src/routes/(console)/project-[region]-[project]/settings/domains/add-domain/verify-[domain]/+page.svelte Replaced updateNameservers with verifyNameservers in the project settings add-domain verification page.
src/routes/(console)/project-[region]-[project]/settings/domains/retryDomainModal.svelte Replaced updateNameservers with verifyNameservers in the project settings retry modal.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/add-domain/verify-[domain]/+page.svelte Replaced updateNameservers with verifyNameservers in the sites add-domain verification page.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/domains/retryDomainModal.svelte Replaced updateNameservers with verifyNameservers in the sites retry modal.

Reviews (2): Last reviewed commit: "Update console SDK preview" | Re-trigger Greptile

@ChiragAgg5k ChiragAgg5k merged commit cfd97e3 into main Jun 26, 2026
4 checks passed
@ChiragAgg5k ChiragAgg5k deleted the fix-domain-nameserver-verification-sdk branch June 26, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants