Skip to content

fix: avoid duplicate region prefix in getApiEndpoint for regional API URLs #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 1 commit into from
Mar 29, 2026
Merged

fix: avoid duplicate region prefix in getApiEndpoint for regional API URLs #2941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/stores/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ export function getApiEndpoint(region?: string): string {
const hostname = url.host; // "hostname:port" (or just "hostname" if no port)

// If instance supports multi-region, add the region subdomain.
const subdomain = isMultiRegionSupported(url) ? getSubdomain(region) : '';
let subdomain = isMultiRegionSupported(url) ? getSubdomain(region) : '';
if (subdomain && hostname.startsWith(subdomain)) {
subdomain = '';
}

return `${protocol}//${subdomain}${hostname}/v1`;
Comment on lines +57 to 62
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 No tests added for the new guard

The getApiEndpoint function is called in many places across the codebase, yet there are no unit tests for this particular fix. A test covering at least the two key scenarios would make the intention clear and prevent regressions:

  1. APPWRITE_ENDPOINT = "https://fra.cloud.appwrite.io" + getApiEndpoint('fra') → should return https://fra.cloud.appwrite.io/v1 (no duplicate prefix)
  2. APPWRITE_ENDPOINT = "https://cloud.appwrite.io" + getApiEndpoint('fra') → should return https://fra.cloud.appwrite.io/v1 (prefix added normally)

Without tests, it is difficult to verify the fix is correct and to protect against future regressions.

}
Expand Down
Loading