Repository navigation
fix(deps): upgrade the langchain stack together - #12
Merged
Merged
Conversation
langchain-core, langchain-openai, langgraph and the MCP adapters pin each other, so a security bump to any one of them cannot install alone. mcp moves too because adapters 0.3 import an API that 1.19 lacks, which only fails at runtime.
🟢 Tier S · Ready to mergeThe dependency pins now upgrade LangChain, LangGraph, and the MCP client stack together. This keeps the related packages on compatible major-version lines.
📂 Walkthrough · 1
✅ Fixed since the last review · 1
Reviewed |
Member
Author
|
@appwrite review |
appwrite
Bot
dismissed
their stale review
November 6, 2026 10:48
The findings that requested changes are resolved. See the summary comment for what is still open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the LangChain stack in one change, replacing #6, #7 and #8. Those PRs can't install on their own because the packages pin each other.
langchain-corelangchain-openailanggraphlangchain-mcp-adaptersmcpmcphas to move as well: with 1.19.0 the install succeeds, butapp.mainfails on import because the adapters needstreamable_http_client.verifywouldn't catch a runtime break like this, as the repo has no tests and only installs dependencies.Verification
I ran
run_turn_streamon Python 3.10 on the old and new pins, against a stub of the OpenAI Responses API. The turn covered routing, acalculatortool call and a streamed answer, and both runs produced the same event stream. Allappmodules also import.I connected to a local MCP server over streamable HTTP as well. On the new pins, MCP tools return content blocks instead of a string;
_previewandcontent_to_textturn those into the same text.Not tested
No real model or Appwrite MCP server was used, so this should be checked on a real turn after deploy, particularly MCP write tools going through
write_guard.create_react_agentstill works here, so I left it in place.Related: appwrite-labs/cloud#7351