Repository navigation
hosted: evaluate parent delegation with the shared zone evaluator - #21
Merged
Merged
Conversation
observeDelegation flagged DNSProbeFailed whenever len(views) != len(servers), but the probe appends the authority views reached through glue after the recursive views, so a correct delegation (observed NS equal to the configured nameServers, authority answering AA) was reported matches=false on the on-prem PoC. Use dnsprobe.EvaluateZone (required views, consistent NS/SOA, authoritative answers) and publish its reason/message as the bounded delegation error; transport errors stay opaque.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live defect (platform on-prem PoC, dns-api 0.4.2):
Zone.status.provider.data.delegationreportedobservedNameServers=[ns1.k0sdlg.internal],matches=false,error=DNSProbeFailedalthough all 24 NS/A/AAAA × UDP/TCP probes against the recursive view and the authority returned NOERROR.observeDelegationtreatedlen(views) != len(policy.servers)as failure, butdnsprobeappends the authority views (reached through glue) after the recursive views, so a correct delegation always had more views than servers.dnsprobe.EvaluateZone(required recursive views present, consistent NS/SOA across views, authorities answering AA) and publish itsReason: Messageas the boundeddelegation.error; transport errors remain the opaqueDNSProbeFailed(no private network details).Full
go test ./...(envtest) +go vetPASS.