fix: Moved expires_in field after scope in OAuth2 DatasourceForm - #42202
fix: Moved expires_in field after scope in OAuth2 DatasourceForm#42202abhijeetnardele24-hash wants to merge 1 commit into
Conversation
|
Thanks for contributing to Appsmith! Credential-free formatting, lint, type, and unit checks will run after GitHub's workflow approval. An Appsmith maintainer will start privileged integration tests or a deploy preview when needed. No action is required from you while this PR has the |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe OAuth2 form now renders ChangesOAuth2 form update
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The OAuth2 expiration field is now grouped directly after scope for Authorization Code datasources without changing its availability or stored field binding. No current merge-readiness risk is identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
This PR moves the
expires_infield right after thescopefield in the OAuth2 datasource configuration form.Previously,
expires_inwas placed at the very end of the form, which made it easy to miss since it was disconnected from the rest of the auth settings. Grouping them together improves the UX when setting up OAuth2.Fixes #31059
Type of change
How Has This Been Tested?
expiresIninput correctly appears below the scope input only when the Authorization Code grant type is selected.