docs: fix Helm README Kubernetes link#41693
docs: fix Helm README Kubernetes link#41693suyua9 wants to merge 2 commits intoappsmithorg:releasefrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdated two Markdown link targets in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
deploy/helm/README.md (1)
25-25:⚠️ Potential issue | 🟡 MinorSame link issue exists here.
Line 25 has the same problem that was fixed on line 19 - the link is missing the
https://protocol and will render as a relative link.🔗 Proposed fix
- * Install kubectl: [kubernetes.io/vi/docs/tasks/tools/install-kubectl/](https://kubernetes.io/vi/docs/tasks/tools/install-kubectl/) + * Install kubectl: [https://kubernetes.io/vi/docs/tasks/tools/install-kubectl/](https://kubernetes.io/vi/docs/tasks/tools/install-kubectl/)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deploy/helm/README.md` at line 25, The markdown link for "Install kubectl" is missing the protocol and is rendering as a relative link; update the link target so it includes the full URL (https://kubernetes.io/vi/docs/tasks/tools/install-kubectl/) instead of the current relative path, mirroring the fix applied earlier for the other link.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@deploy/helm/README.md`:
- Line 25: The markdown link for "Install kubectl" is missing the protocol and
is rendering as a relative link; update the link target so it includes the full
URL (https://kubernetes.io/vi/docs/tasks/tools/install-kubectl/) instead of the
current relative path, mirroring the fix applied earlier for the other link.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b0964894-e3c6-498a-9cd4-0c56d7458b98
📒 Files selected for processing (1)
deploy/helm/README.md
Summary
https://scheme to the Kubernetes link indeploy/helm/README.mdProblem
The Helm README currently links Kubernetes as
[Kubernetes](kubernetes.io), which renders as a relative link instead of opening the Kubernetes website.Solution
https://kubernetes.ioCommunication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit