Fix destroy retry exit code #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2025 17:45
When the destroy command retried a failed deletion and succeeded, it would still exit with a non-zero code because the recursive call to destroy() was missing a return statement. This caused the code to fall through to the error return even after a successful retry, making CI tests fail despite successful deletion. Changes: - Added return statement to destroy() recursive call on line 70 - Now properly returns success when retry succeeds - Fixes false failures in functional tests
This reverts commit 2849ef3.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the destroy command's retry logic where the exit code from a successful retry was not being properly returned, causing the command to report failure even when the retry succeeded. With this fix, the manual retry logic in CI workflows can be removed.
- Fixed missing
returnstatement in destroy retry logic to properly propagate exit codes - Removed redundant manual retry logic from GitHub Actions workflows
- Simplified workflow commands for cluster destruction
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/destroy.go | Added return statement to properly propagate the exit code from recursive destroy retry call |
| .github/workflows/functional_tests.yml | Removed manual retry logic for cluster destruction now that exit codes are properly handled in code |
| .github/workflows/databases.yml | Removed manual retry logic for cluster destruction now that exit codes are properly handled in code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.