Handle LoadBalancerNotFound error during cluster deletion #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disabling deletion protection during cluster deletion (PreDelete), gracefully handle the case where the load balancer no longer exists. This can happen if the load balancer was manually deleted or the stack is in a failed state. - Add LoadBalancerNotFoundException error handling - Log as debug and continue with stack deletion instead of failing - Only applies when turning deletion protection off (value=false) - Turning deletion protection on still returns errors as expected
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the robustness of cluster deletion by gracefully handling cases where the load balancer has already been removed. When disabling deletion protection during the PreDelete phase, the code now catches LoadBalancerNotFoundException and logs it as a debug message instead of failing the deletion process.
- Adds error handling for LoadBalancerNotFoundException when disabling deletion protection
- Maintains strict error handling when enabling deletion protection
- Aligns with existing error handling pattern in the same function for missing CloudFormation outputs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling deletion protection during cluster deletion (PreDelete), gracefully handle the case where the load balancer no longer exists. This can happen if the load balancer was manually deleted or the stack is in a failed state.