AWS SDK v2 upgrade #106
Merged
AWS SDK v2 upgrade #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase from AWS SDK for Go v1 to v2, a significant update that modernizes the AWS service interactions. The migration includes updating all AWS service clients, changing from pointer-based to value-based types, and introducing proper context usage throughout.
Key Changes:
- Migrated from
github.com/aws/aws-sdk-gotogithub.com/aws/aws-sdk-go-v2with all required service packages - Replaced
*session.Sessionwithaws.Configthroughout the codebase - Added
context.Background()to all AWS API calls per SDK v2 requirements - Updated CloudFormation, DynamoDB, ECS, SSM, and other AWS service usage patterns to match v2 SDK patterns
Reviewed Changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod, go.sum | Added AWS SDK v2 dependencies and removed v1-specific packages |
| version/version_test.go | Updated context usage from context.TODO() to context.Background() |
| stacks/*.go | Migrated all stack operations to SDK v2 with proper type conversions and context usage |
| bridge/*.go | Updated CloudFormation and Route53 bridge functions to use SDK v2 |
| auth/*.go | Replaced session-based auth with aws.Config and added new console URL generation |
| app/*.go | Comprehensive SDK v2 migration including DynamoDB, ECS, SSM, and S3 operations |
| cmd/*.go | Updated all command implementations to use aws.Config instead of sessions |
| metrics/metrics.go | Updated CloudWatch metric queries to use SDK v2 types |
| ddb/ddb.go | Migrated DynamoDB operations and attribute value handling to SDK v2 |
| aws/*.go | Updated internal AWS wrappers to use aws.Config and SDK v2 patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Resolved conflicts in multiple files to complete AWS SDK v1 to v2 migration: - app/app.go: Combined StartBuild function improvements with v2 SDK types - app/builds.go: Kept v2 SDK imports - cmd/access.go: Combined default parameters logic with v2 SDK types - cmd/modify.go: Converted from session.Session to aws.Config - stacks/app_pipeline.go: Added helper question functions, fixed newline literals - stacks/interfaces.go: Converted from v1 to v2 types with improved field mapping
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 48 out of 49 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.