Build ref flag #105
Merged
Build ref flag #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional --ref flag to `build start` command to allow building from
specific git references (branches, tags, or commit hashes).
Changes:
- Add --ref flag to buildStartCmd (cmd/build.go)
- Update StartBuild() signature to accept ref parameter (app/app.go)
- Extract DetermineBuildSourceVersion() helper function for testability
(app/builds.go)
- Add comprehensive unit tests for DetermineBuildSourceVersion()
(app/builds_test.go) with 100% coverage
- Update reviewapps.go to pass empty ref to StartBuild()
The --ref flag accepts any git reference that CodeBuild supports:
- Branch names: --ref develop
- Tags: --ref v1.2.3
- Commit hashes: --ref abc123def456
When no --ref is provided, CodeBuild uses the default branch configured
in the project. Review apps continue to use the pr/{number} format and
take precedence over the --ref flag.
The core logic is extracted into DetermineBuildSourceVersion(), a pure
function that determines the appropriate SourceVersion parameter based
on whether the app is a review app and if a custom ref is provided.
This design makes the logic easy to test without mocking AWS services.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for building from custom git references by introducing a --ref flag to the build start command. The implementation extracts build source version determination logic into a testable helper function.
- Added
--refflag to allow building from specific branches, tags, or commit hashes - Refactored build source version logic into
DetermineBuildSourceVersionfunction with comprehensive test coverage - Updated
StartBuildmethod signature to accept the ref parameter
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Documents the new --ref flag feature and Go version update |
| app/builds.go | Introduces DetermineBuildSourceVersion helper function to centralize source version logic |
| app/builds_test.go | Adds comprehensive test coverage for the new helper function |
| app/app.go | Refactors StartBuild to use the new helper function and accept ref parameter |
| cmd/build.go | Adds --ref flag declaration and passes it to StartBuild |
| cmd/reviewapps.go | Updates StartBuild call to pass empty string for ref parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.