Skip to content

Conversation

@ipmb
Copy link
Member

@ipmb ipmb commented Nov 9, 2025

No description provided.

@ipmb ipmb requested a review from Copilot November 9, 2025 19:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a modify app command for updating application/pipeline parameters and fixes an issue where stack updates could revert parameters to template defaults. Key changes include:

  • Introduces cfnparam struct tags for mapping Go field names to CloudFormation parameter names (e.g., RepositoryURL -> RepositoryUrl)
  • Updates PruneUnsupportedParameters to use UsePreviousValue for parameters not being explicitly set
  • Renames struct fields to follow Go naming conventions (SesDomain -> SESDomain, AppPackRoleExternalID -> AppPackRoleExternalID, etc.)

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ui/questions.go Adds StringValueProxy type for direct string value handling in survey questions
stacks/review_app_test.go Adds comprehensive test coverage for IsReviewAppName function
stacks/review_app.go Introduces IsReviewAppName helper function to identify review apps by naming convention
stacks/interfaces_test.go Adds tests for cfnparam tag mapping and parameter pruning behavior
stacks/interfaces.go Implements cfnparam tag support for bidirectional CloudFormation parameter mapping and enhances PruneUnsupportedParameters to preserve unmodified parameters
stacks/app_pipeline.go Renames fields to Go conventions, adds cfnparam tags, extracts reusable question builder functions, and exports VerifySourceCredentials
cmd/modify.go Implements new modify app command supporting both interactive and flag-based parameter updates with review app protection
cmd/access.go Updates appOrPipelineStack to initialize with default parameters before loading from CloudFormation
Makefile Simplifies fmt target to use golangci-lint's built-in formatter
CHANGELOG.md Documents new features and fixes
.golangci.toml Configures gofumpt and gci formatters for golangci-lint

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ipmb and others added 2 commits November 9, 2025 13:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ipmb ipmb merged commit 3f14d26 into main Nov 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants