Conversation
Hokila
requested review from
deccylol,
jakepetroules,
jonathanjhess and
rconnell9
as code owners
September 17, 2026 09:41
Author
|
Two integration questions for maintainer guidance:
Local validation passes with Xcode 27.2 beta: full SwiftPM Debug and Release runs, focused tests with the native SwiftPM build system and fresh scratch directory, and Xcode clean package tests with fresh DerivedData. The 10 new tests include executable-discovery isolation, large-output capture, and timeout cleanup. Existing performance tests are cancelled by the repository's guard in the tested configurations. |
Cover CLI input/output and in-place updates with golden fixtures. Resolve the executable from the current build and bound subprocess execution, with regression tests for discovery isolation, large output, and timeout cleanup.
Hokila
force-pushed
the
test/xcprojformatter-e2e
branch
from
September 17, 2026 16:13
d404017 to
3fdc001
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
Add end-to-end tests for the compiled
xcprojformatterexecutable to catch regressions in CLI input/output handling, formatting, and in-place updates. A malformed update must fail without changing the original file.Related issue
Standalone coverage of existing functionality; no related issue.
Changes
XcodeProjectToolTestswith seven CLI tests covering help, stdin/stdout, positional input, inner and outer project paths, file output, and successful and failed in-place updates.BUILT_PRODUCTS_DIRor the test/resource bundle location.XCPROJFORMATTER_PATHcan explicitly select an executable. Missing executables fail with the attempted path; discovery does not recursively scan directories or fall back to other builds.No production code, CLI behavior, public API, or schema changes. Full CLI error-matrix coverage is outside this PR.
Testing
Validated locally on macOS with Xcode 27.2 beta:
swift testswift test -c releaseswift test --build-system native --scratch-path <temporary-directory> --filter 'XcodeProjectToolTests|ToolTestSupportTests'xcodebuild -scheme xcode-project-format-Package -destination 'platform=macOS' -derivedDataPath <temporary-directory> clean testgit diff --checkAll 10 new tests pass. Existing performance tests are cancelled by the repository's performance-test guard in the tested configurations; these runs do not claim performance-test coverage. Other platforms were not validated.
Checklist