Integer serialization fix for 32 bit platform compatibility #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: [RFC 9651](https://www.ietf.org/rfc/rfc9651.html) permits serializing an integer in the range of -999,999,999,999,999 to 999,999,999,999,999 inclusive ([Section 4.1.4-2.1.1](https://www.ietf.org/rfc/rfc9651.html#section-4.1.4-2.1.1)). As `RFC9651BareItem` takes values `integer` or `date` with an associated value of type `Int`, that range is implicitly more constrained on 32-bit platforms to a subset range of `-Int32.min` to `Int32.max` inclusive. Modifications: - Adjust `RFC9651BareItem` to take values `integer` or `date` with an associated value of type `Int64` instead, which is sufficient for the permitted range. Result: Compatibility for the Integer and Date Structured Types on 32-bit platforms.
clintonpi
force-pushed
the
integer-serialization-fix-for-32-bit-platform-compatibility
branch
from
0dde4ce to
fb72db4
Compare
Contributor
|
API breakage is expected, we haven't shipped the API we're breaking. |
clintonpi
deleted the
integer-serialization-fix-for-32-bit-platform-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RFC 9651 permits serializing an integer in the range of -999,999,999,999,999 to 999,999,999,999,999 inclusive (Section 4.1.4-2.1.1). As
RFC9651BareItemtakes valuesintegerordatewith an associated value of typeInt, that range is implicitly more constrained on 32-bit platforms to a subset range ofInt32.mintoInt32.maxinclusive.Modifications:
RFC9651BareItemto take valuesintegerordatewith an associated value of typeInt64instead, which is sufficient for the permitted range.Result:
Compatibility for the Integer and Date Structured Types on 32-bit platforms.