Support in-place PyTorch bitwise and logical ops (__ior__, __iand__, __ixor__) - #2816
Open
jaseem-kurikkal wants to merge 1 commit into
Open
Conversation
Collaborator
|
This change looks good. CI: https://gitlab.com/coremltools1/coremltools/-/pipelines/2767223028 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for in-place PyTorch logical and bitwise operators (
__ior__,__iand__,__ixor__, i.e.,|=,&=,^=) in the PyTorch frontend.Context / Motivation
Modern transformer and LLM architectures (such as attention mask construction in Gemma and LLaMA) make frequent use of in-place boolean masking (
mask1 |= mask2). When converted, PyTorch emitsaten::__ior__,aten::__iand__, andaten::__ixor__nodes (sanitized toior,iand,ixor), which previously raised:NotImplementedError: PyTorch convert function for op 'ior' not implemented.
Changes
iand,ior, andixoraliases forbitwise_and,bitwise_or, andbitwise_xorincoremltools/converters/mil/frontend/torch/ops.py.test_and_operator,test_iand_operator,test_ior_operator,test_xor_operator,test_ixor_operator) incoremltools/converters/mil/frontend/torch/test/test_torch_ops.pycovering TorchScript and TorchExport across all backend and compute unit permutations.Testing
Ran:
pytest coremltools/converters/mil/frontend/torch/test/test_torch_ops.py -k "TestBitwise"