feat: Remove torch upper bound and add untested warning - #98
Merged
Merged
Conversation
guru-desh
changed the title
guru-desh
force-pushed
the
add-torch-version-warning
branch
from
September 16, 2026 20:44
0bbc193 to
3ca8113
Compare
guru-desh
changed the title
guru-desh
changed the title
guru-desh
marked this pull request as ready for review
September 16, 2026 22:25
dengqiaoyu
reviewed
Sep 17, 2026
dengqiaoyu
reviewed
Sep 17, 2026
dengqiaoyu
approved these changes
Sep 17, 2026
dengqiaoyu
force-pushed
the
add-torch-version-warning
branch
from
September 17, 2026 00:44
4a2e7f1 to
67cfb91
Compare
guru-desh
force-pushed
the
add-torch-version-warning
branch
from
September 17, 2026 03:58
903746c to
f8ddfe6
Compare
…orch # Conflicts: # src/coreai_opt/__init__.py
…torch_matches_pyproject
Replaces the manual (major, minor) tuple comparison with packaging.specifiers.SpecifierSet, matching the version_ge helper's existing dependency on packaging.specifiers.
Introduces DependencyVersionWarning as a common base, with UntestedTorchVersionWarning and TorchaoTorchIncompatibilityWarning as subclasses, replacing the plain UserWarning previously used for both checks. Lets callers filter by category (warnings.filterwarnings or pytest's filterwarnings) instead of matching on message text, and filter both checks at once via the shared base class.
Introduces DependencyVersionWarning as a common base, with UntestedTorchVersionWarning and TorchaoTorchIncompatibilityWarning as subclasses, replacing the plain UserWarning previously used for both checks. Lets callers filter by category (warnings.filterwarnings or pytest's filterwarnings) instead of matching on message text, and filter both checks at once via the shared base class.
CI's make check caught table-order drift in [tool.setuptools.*] (package-data/dynamic vs packages.find). Verified idempotent with pyproject-fmt run directly against the pinned config/version.
apple/main added a torch_2_14 dependency group, CI smoke job, and HIGHEST_TORCH_GROUP := torch_2_14 (apple#99), so 2.14 is now genuinely covered by CI. Bump _MAX_TESTED_TORCH to match, as test_max_tested_torch_matches_pyproject requires, and shift the untested-version fixtures up one minor.
guru-desh
force-pushed
the
add-torch-version-warning
branch
from
September 17, 2026 05:46
8a6bd8b to
c16a56b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.