fix(cli): support context-less builds via standard input (fixes #2139) - #2147
Open
manideep-malyala wants to merge 1 commit into
Open
fix(cli): support context-less builds via standard input (fixes #2139)#2147manideep-malyala wants to merge 1 commit into
manideep-malyala wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #2139 by adding support for context-less builds via
container build - < Dockerfile, aligning with standard Docker CLI behavior.Changes Made
BuildCommand.swift'svalidate()method so that ifcontextDiris"-", it correctly bypasses theFileManager.default.fileExistscheck (which previously threwcontext dir does not exist -).-fis explicitly provided andcontextDiris"-",dockerfilecorrectly defaults to"-"(stdin).run()closure to generate and pass an empty temporary directory (empty-context) to theBuilder.BuildConfigwhencontextDiris"-". This satisfies the underlyingContainerBuildengine requirements while gracefully supplying a truly empty context to the builder.Fixes #2139.