fix(image): preserve active and infrastructure aliases - #2128
Open
stephenlclarke wants to merge 1 commit into
Open
fix(image): preserve active and infrastructure aliases#2128stephenlclarke wants to merge 1 commit into
stephenlclarke wants to merge 1 commit into
Conversation
Match active images by OCI digest and configured infrastructure images by normalized aliases. Store the fetched builder reference so equivalent aliases neither recreate the builder nor become prune candidates. Fixes apple#2030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #2030.
Use OCI digests as active-image identity, normalize configured infrastructure aliases, and persist the fetched builder reference. This prevents
image prune --allfrom deleting a normalized image used by an active builder and avoids unnecessary builder recreation.This supersedes the earlier closed #2031, rebased onto current
main.Testing
Negative control with the former reference-only decisions: three alias cases and the digest identity regression failed.
make fmt,make check, andgit diff --check: passed