fix(persistence): preserve unloadable container bundles - #2127
Open
stephenlclarke wants to merge 1 commit into
Open
fix(persistence): preserve unloadable container bundles#2127stephenlclarke wants to merge 1 commit into
stephenlclarke wants to merge 1 commit into
Conversation
Keep malformed or temporarily unloadable bundles on disk and validate the runtime plugin before publishing in-memory state. Write bundle metadata atomically so interrupted updates cannot expose partial JSON. Fixes apple#2033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #2033.
Preserve malformed or temporarily unloadable container bundles instead of deleting user state during startup. Validate runtime availability before publishing in-memory state, and atomically replace bundle metadata to avoid exposing interrupted JSON writes.
This supersedes the earlier closed #2035 with strengthened malformed-current-and-legacy configuration coverage, rebased onto current
main.Testing
Negative control on current
main: malformed bundles were deleted and missing-runtime state was returned before its bundle was deleted.make fmt,make check, andgit diff --check: passed