Fix foreground process signal forwarding#1871
Open
Jalendar10 wants to merge 1 commit into
Open
Conversation
Jalendar10
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix foreground process signal forwarding so signals sent from the CLI are encoded in the format expected by the container API service.
Root cause
ClientProcess.kill(_:)was writing the XPCsignalfield as an integer, but the container service reads that field as a string. During foreground process handling this could surface asmissing signal in xpc message.SIGWINCHwas also included in the generic signal-forwarding set even though TTY sessions already use the dedicated resize route, which made terminal resize events especially noisy.Changes
SIGINTandSIGTERM.SIGWINCHfrom the generic kill-signal forwarding set so resize events stay on the terminal resize path.ContainerAPIClientTestscoverage for signal-name encoding and resize-signal exclusion.Fixes #1747.
Validation
swift test --filter ProcessIOTestsswift test --filter ContainerAPIClientTests