Print warning message when page cache thrashing is detected#1605
Open
JaewonHur wants to merge 2 commits into
Open
Print warning message when page cache thrashing is detected#1605JaewonHur wants to merge 2 commits into
JaewonHur wants to merge 2 commits into
Conversation
Container build process can (seemingly) hang when a lots of threads contend for the disk IO, thrashing each other's page cache. User had no means to tell the hang is due to this issue or the issue in Dockerfile itself. This PR makes build procedure print warning message on thrashing is detected.
Code Coverage
|
jglogan
approved these changes
May 29, 2026
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
Approved but see comment.
| while true { | ||
| let stdout = Pipe() | ||
|
|
||
| let process = try await client.createProcess( |
Contributor
There was a problem hiding this comment.
Any throwing non-cancel error in here will kill the build, I think. Is this ok?
Member
|
We have |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container build process can (seemingly) hang when a lots of threads contend for the disk IO, thrashing each other's page cache. User had no means to tell the hang is due to this issue or the issue in Dockerfile itself. This PR makes build procedure print warning message on thrashing is detected.
Type of Change
Motivation and Context
Help users root causing the hang while
container buildTesting