Add support for legacyHttpTransport flag
#235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-friedl
force-pushed
the
dev/enable-legacy-http-transport
branch
from
bf2dbdf to
85abc76
Compare
alex-friedl
force-pushed
the
dev/enable-legacy-http-transport
branch
from
85abc76 to
894bee1
Compare
alex-friedl
changed the title
legacyHttpTransport flag
Based on research and feedback from issue #220: - Remove httpsAgent support (Firebase only supports httpAgent in AppOptions) - Pass httpAgent to credential factory for proper authentication proxy support - Single httpAgent parameter handles both HTTP and HTTPS connections - Update documentation to clarify httpAgent usage with HttpsProxyAgent for HTTPS proxies - Update tests to reflect httpAgent-only configuration - Maintain legacyHttpTransport support for HTTP/1.1 transport All 88 tests passing (87 existing + 1 legacyHttpTransport test) Simplify credential assignment using || operator Replace if/else block with more concise || operator for getting or creating credential with httpAgent support. Maintains same functionality while improving readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220