Repository navigation
ADFA-7214 | AI Agent Local: load models picked from shared storage on API 36 #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
a0e4e3f
ADFA-7214 | AI Agent Local: load models picked from shared storage on…
hal-eisen-adfa 152f5be
ADFA-7214 | AI Agent Local: also load msf: documents from the Downloa…
hal-eisen-adfa 5c1f888
Merge branch 'main' into ADFA-7214-local-model-download-load
hal-eisen-adfa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve file identity across fallback validation and loading.
If another process replaces the resolved pathname with a same-size file, both fallback checks pass. The method then closes the selected document's descriptor and returns a handle that reads the replacement. Replacement after validation is also possible because the handle retains only the pathname. The native backend subsequently passes that pathname to
llama.load. (raw.githubusercontent.com)Keep a verified shared-storage descriptor for inspection and native loading instead of reopening an unchecked pathname. Preserve the required SAF-descriptor closure before mmap. Test same-size replacement as well as the unchanged-file case.
Based on learnings, pathname validation followed by a separate pathname open creates a TOCTOU race.
Source: Learnings